Skip to content

remove android support annotations#26320

Closed
dulmandakh wants to merge 1 commit into
facebook:masterfrom
dulmandakh:android-ci-fix
Closed

remove android support annotations#26320
dulmandakh wants to merge 1 commit into
facebook:masterfrom
dulmandakh:android-ci-fix

Conversation

@dulmandakh
Copy link
Copy Markdown
Contributor

@dulmandakh dulmandakh commented Sep 4, 2019

Summary

Remove Android Support Library annotations dependency since we migrated to AndroidX.

Changelog

[Android] [Changed] - remove android support annotations

Test Plan

./scripts/circleci/buck_fetch.sh script completes without error.

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Contributor A React Native contributor. labels Sep 4, 2019
@dulmandakh dulmandakh requested a review from elicwhite September 4, 2019 07:50
facebook-github-bot
facebook-github-bot approved these changes Sep 4, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TheSavior is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@react-native-bot react-native-bot added the Platform: Android Android applications. label Sep 4, 2019
@gengjiawen
Copy link
Copy Markdown
Contributor

gengjiawen commented Sep 4, 2019

@dulmandakh Build still failed with, dep missing in Buck ?

stderr: /root/react-native/ReactAndroid/src/main/java/com/facebook/jni/Countable.java:21: error: cannot find symbol
@DoNotStrip
 ^
  symbol: class DoNotStrip
/root/react-native/ReactAndroid/src/main/java/com/facebook/jni/CpuCapabilitiesJni.java:12: error: cannot find symbol
@DoNotStrip
 ^
  symbol: class DoNotStrip
/root/react-native/ReactAndroid/src/main/java/com/facebook/jni/HybridData.java:19: error: cannot find symbol
@DoNotStrip
 ^
  symbol: class DoNotStrip
/root/react-native/ReactAndroid/src/main/java/com/facebook/jni/HybridClassBase.java:10: error: cannot find symbol
@DoNotStrip
 ^

@dulmandakh
Copy link
Copy Markdown
Contributor Author

dulmandakh commented Sep 4, 2019

@gengjiawen yep, it wasn't reaching to this issue before.

@react-native-bot
Copy link
Copy Markdown
Collaborator

react-native-bot commented Sep 5, 2019

This pull request was successfully merged by @dulmandakh in a2f513e.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Sep 5, 2019
@dulmandakh dulmandakh deleted the android-ci-fix branch October 15, 2019 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@elicwhite elicwhite Awaiting requested review from elicwhite

2 more reviewers

@gengjiawen gengjiawen gengjiawen approved these changes

@facebook-github-bot facebook-github-bot facebook-github-bot approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Contributor A React Native contributor. Merged This PR has been merged. Platform: Android Android applications.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dulmandakh @gengjiawen @react-native-bot @facebook-github-bot